New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple Delegation #34

Merged

katamarinaki merged 106 commits into master from voting-manager

Dec 19, 2024

Member

ujenjt commented Jan 25, 2024 •

edited by katamarinaki

Loading

The Simple Delegation update allows LDO token holders to delegate their voting power to other addresses and delegates to participate in on-chain voting on behalf of their delegated voters.

This code was audited by Ackee and Statemind.

ujenjt added 2 commits

January 25, 2024 14:13


          chore: add voting manager feature for holders

8b8ef36


          chore: Prohibit managers from overwriting holder's votes, retain over…

c1fa2f1

…ride for holders

skozin reviewed

View reviewed changes

apps/voting/contracts/Voting.sol Outdated Show resolved Hide resolved

apps/voting/contracts/Voting.sol Outdated Show resolved Hide resolved

krogla reviewed

View reviewed changes

apps/voting/contracts/Voting.sol Outdated Show resolved Hide resolved

krogla reviewed

View reviewed changes

apps/voting/contracts/Voting.sol Outdated Show resolved Hide resolved

Member

krogla commented Jan 25, 2024

...I would replace voteFor with a method like voteByManager, where I wouldn't pass a list of addresses, but simply check if the msg.sender address has any under its management, and if so, vote on their behalf in a loop. Of course, it would require adding chunks, but then it seems we could simplify the logic of checking whether the manager's vote matches the delegate's vote.

folkyatina reviewed

View reviewed changes

apps/voting/contracts/Voting.sol Outdated Show resolved Hide resolved

Psirex reviewed

View reviewed changes

apps/voting/contracts/Voting.sol Outdated Show resolved Hide resolved

zuzueeka reviewed

View reviewed changes

apps/voting/contracts/Voting.sol Outdated Show resolved Hide resolved

zuzueeka reviewed

View reviewed changes

apps/voting/contracts/Voting.sol Outdated Show resolved Hide resolved

katamarinaki added 20 commits

February 7, 2024 16:11


          fix: internal function types

52a6524


          refactor: rename holder -> voter, manager -> delegate

7ed76a8


          refactor: update delegation related naming in tests

740bb2b


          refactor: extract vote phase check into separate fn

739ae34


          refactor: add CastVoteAsDelegate event

7392eb4


          refactor: introduce Delegate struct and use it to simplify DelegatedA…

978b4eb

…ddressList management


          feat: add balance check to setDelegate

e8c7965


          refactor: remove reverts from voteForMultiple and _vote, move revert …

baa1a71

…check from _vote to voteFor


          fix: update voterIndex of swapped address during voter deletion

1d98abf


          refactor: remove voterIndex from DelegateSet event

81a75b7


          refactor: remove MAX_VOTERS_PER_DELEGATE limitation

b040619


          refactor: add offset and count params to getDelegatedVoters

337b031


          refactor: remove unused constant

f98f68d


          refactor: add revert if error inside loop in voteForMultiple

4d6f150


          refactor: add getter for delegated voters with their voting power and…

7bf4014

… voting state


          refactor: optimize delegated voter removal

c3f8577


          refactor: add max uint96 check for delegated voters array length


          refactor: remove unused variables from Voting contract


          refactor: rebuild invariant checks for voteForMultiple, refactor voteFor

42bb8f3


          refactor: update delegation getters and setters

569a600

katamarinaki and others added 12 commits

June 25, 2024 20:01


          docs: update comments and docs

19f14bc


          fix: move snapshotBlock getter out of the loop

456cb54


          refactor: replace _isVoteOpen with a comprehensive version of _getVot…

375573c

…ePhase and _isValidPhaseToVote


          docs: add VoterState values descriptions

f1283de


          docs: fix comment

079dd88


          test: rework delegation tests

feb1515


          fix: remove unused function

714d7c8


          fix: remove unreachable code

30c8ccb


          fix: declare _voters.length before loop

3680b5a


          docs: fix natspec format

50d9802


          docs: update canVote comment

c112cc2


          Merge pull request #44 from lidofinance/refactor/simple-delegation

6a431b6

Simple Delegation Refactor

Psirex previously approved these changes

View reviewed changes


          fix: revert yarn.lock changes

0ec288b

katamarinaki dismissed Psirex’s stale review via

0ec288b

October 16, 2024 15:03


          ci: fix verify-bytecode workflow (#47)

8892e18

* fix: bumb node to 18, update yarn.lock

katamarinaki requested review from krogla and removed request for krogla

December 17, 2024 12:05

katamarinaki dismissed krogla’s stale review

December 17, 2024 12:07

All issues were resolverd

katamarinaki and others added 8 commits

December 17, 2024 13:25


          fix: update node in verify-bytecode action

c88466e


          Merge pull request #48 from lidofinance/fix/verify-bytecode-ci

8b81180

fix: update node in verify-bytecode action


          fix: add cache clean step to verify-bytecode action

c54aea4


          fix: ci


          fix: revert verify-bytecode action code

481f892


          fix: ci

2a6c852


          fix: artifacts

3cd99c0


          fix: artifacts

a059505

Psirex approved these changes

View reviewed changes

katamarinaki merged commit a7d0e33 into master

1 check passed

katamarinaki deleted the voting-manager branch

December 19, 2024 11:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zuzueeka zuzueeka left review comments

dgusakov dgusakov left review comments

katamarinaki katamarinaki left review comments

kadmil kadmil left review comments

skozin skozin left review comments

folkyatina folkyatina left review comments

Psirex Psirex approved these changes

krogla krogla left review comments

bulbozaur bulbozaur left review comments

Labels

None yet