Use if always(), and skip PRs with a milestone

lidavidm · Nov 16, 2023 · d82ff04 · d82ff04
1 parent 1ac2dfa
commit d82ff04
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.github/workflows/dev_pr.yml b/.github/workflows/dev_pr.yml
@@ -38,7 +38,6 @@ jobs:
           persist-credentials: false
 
       - name: Check title for Conventional Commits format
-        continue-on-error: true
         if: |
           github.event_name == 'pull_request_target' &&
             (github.event.action == 'opened' ||
@@ -51,7 +50,7 @@ jobs:
             await script({github, context});
 
       - name: Assign milestone
-        continue-on-error: true
+        if: always()
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |

diff --git a/.github/workflows/dev_pr/milestone.sh b/.github/workflows/dev_pr/milestone.sh
@@ -26,10 +26,20 @@ main() {
     local -r pr_number="${2}"
     echo "On ${repo} pull ${pr_number}"
 
+    local -r existing_milestone=$(gh pr view "${pr_number}" \
+                                  --json milestone \
+                                  -t '{{if .milestone}}{{.milestone.title}}{{else}}{{end}}')
+
+    if [[ ! -z "${existing_milestone}" ]]; then
+        echo "PR has milestone: ${existing_milestone}"
+        return 0
+    fi
+
     local -r latest_version=$(git ls-remote --heads origin |
                                   grep -o '[0-9.]*$' |
                                   sort --version-sort |
                                   tail -n1)
+
     local -r milestone=$(gh api "/repos/${repo}/milestones" |
                              jq -r '.[] | .title' |
                              grep -E '^ADBC Libraries' |