Added custom exception (inheriting from KeyError) when deserialization fails #207
Conversation
|
Hmm, why did the second try get cancelled? I think it should have passed the linter this time |
eblis
force-pushed
the
deserialization-exception
branch
from
177ef80 to
64cd7b1
Compare
eblis
force-pushed
the
deserialization-exception
branch
from
64cd7b1 to
7031df5
Compare
dataclasses_json/errors.py
Outdated
| @@ -0,0 +1,3 @@ | |||
| class DataclassSerializationException(KeyError): | |||
There was a problem hiding this comment.
perhaps class DataclassJsonError(Exception) instead, to make it clear it's coming from this package, not dataclasses itself -- user-defined exceptions typically inherit from Exception
There was a problem hiding this comment.
It's weird not inheriting from Exception but I wanted to inherit from KeyError so that any client code that might have caught the old exception would still catch the new one.
I feel like inheriting from Exception would be a bit of a breaking change .. fine by me, but not sure if everyone would feel that way.
There was a problem hiding this comment.
gotcha, that's a good thought and thanks for clarifying
|
see #206 (comment) |
…lassJson). Added base exception, but currently not inheriting from that.
I have added a quickly put together patch that helps with issue #206, it will raise a custom exception (that inherits from KeyError from clients that were catching that exception) and reports the actual object that failed and the field it failed for.