Use caching to improve performance #148
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dataclasses-json is very slow when parsing lists of objects because it introspects the dataclasses every time. This pull request caches the slowest of those calls using python's built-in
lru_cache
, Reducing the decoding time for my test json from 21s to 2.1s.There are commits: With 56c3c9d the already failing test keeps failing, while the remainder of the tests passes. With cbe4d87 pytest fails on collecting tests cases due to some type being unhashable.