Fix small test conversion #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenguyenthanh
force-pushed
the
fix-small-test-conversion
branch
from
c3a2cec to
a18162a
Compare
This happen when in White's turn, and there is a enpassant on b6. Before this fix, it is mistaken the b from b6 as Black's turn. So, the fix is make sure that only set black turn if there is no number after character b.
lenguyenthanh
force-pushed
the
fix-small-test-conversion
branch
from
a18162a to
32defa1
Compare
ornicar
reviewed
Dec 14, 2023
| @@ -92,7 +92,7 @@ object SmallFen extends OpaqueString[SmallFen]: | |||
| val (board, error) = Fen.makeBoardWithCrazyPromoted(e, chess.variant.Standard) | |||
| val boardStr = Fen.writeBoard(board) | |||
| val boardSize = boardStr.value.count(_ != '/') | |||
| val isBlackTurn = e.lift(boardSize).exists(_ == 'b') | |||
| val isBlackTurn = e.lift(boardSize).exists(_ == 'b') && !e.lift(boardSize + 1).exists(_.isDigit) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happen when in White's turn, and there is a enpassant on b6.
Before this fix, it is mistaken the b from b6 as Black's turn. So,
the fix is make sure that only set black turn if there is no number
after character b.