Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-game chat feature #339

Merged
merged 26 commits into from
Dec 13, 2023
Merged

In-game chat feature #339

merged 26 commits into from
Dec 13, 2023

Conversation

julien4215
Copy link
Contributor

@julien4215 julien4215 commented Oct 13, 2023 •
edited
Loading

In-game chat feature #279

  • Create the in-game chat screen
  • Add message icon to the game screen
  • Add server message (like "Draw offer")
  • Improve the color of bubbles messages
  • Create iOS builder
  • Edit game controller

@julien4215 julien4215 changed the title Add in-game chat feature In-game chat feature Oct 13, 2023
@julien4215 julien4215 mentioned this pull request Oct 13, 2023
Closed
2 tasks
@julien4215 julien4215 force-pushed the in-game_chat branch 2 times, most recently from ee8422e to 4b758b3 Compare October 22, 2023 19:34
@julien4215 julien4215 marked this pull request as draft October 29, 2023 09:27
@julien4215 julien4215 marked this pull request as ready for review December 5, 2023 07:09
veloce
veloce reviewed Dec 6, 2023
View reviewed changes
Copy link
Contributor

@veloce veloce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good! thank you for your work, I think it's almost done as the comments I've made only require easy refactoring, I think :)

lib/src/model/game/chat_controller.dart Outdated Show resolved Hide resolved
lib/src/model/game/chat_controller.dart Outdated Show resolved Hide resolved
lib/src/model/game/chat_controller.dart Outdated Show resolved Hide resolved
lib/src/view/game/game_body.dart Outdated Show resolved Hide resolved
lib/src/view/game/game_body.dart Outdated Show resolved Hide resolved
lib/src/view/game/message_screen.dart Outdated Show resolved Hide resolved
lib/src/view/game/message_screen.dart Outdated Show resolved Hide resolved
@julien4215
Add the user interface for in-game chat
c66297a
@julien4215
change bubble message color in light and dark mode
655ee22
@julien4215
add messages from server like "Draw offer sent"
17c7c85
@julien4215
Fix in-game chat screen title
33ef47f 
-replace player name by opponent name
-add opponent title next to his name
@julien4215
-edit controller to receive and send messages
8a289d9 
-add a message class
-edit server message style
-badge on the chat icon shows the number of unread messages
@julien4215
Improvements of chat bottom bar
92276ed 
-disable send button when no text entered
-shape circular instead of rectangular
@julien4215
-factoring code
c2d6c68 
-add iOS builder
@julien4215
small improvements/fixs
eb61bea
@julien4215
rename bottom bar class for message screen
8d3b5f3
@julien4215
refactor controller
d074edf
@julien4215
fix test
3a63d7d
@julien4215
make chat controller more generic
6b58cea
@julien4215
make message screen more generic
f7afd54
@veloce veloce merged commit 0ba340b into lichess-org:main Dec 13, 2023
3 checks passed
@julien4215 julien4215 deleted the in-game_chat branch January 4, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veloce veloce veloce left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien4215 @veloce