feat: show chapter numbers #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veloce
approved these changes
Feb 14, 2025
|
Thanks! |
|
@vincendep wouls you agree the mobile web styling for numbers looks better than plaintext (bolder and blue)?
|
|
Hi @ijm8710, yes I agree with you. Should the issue be reopened so I can make another pull request? |
|
Hmm idk on that one or if can just prepare a quick PR update and see if Veloce is good to accept? |
|
@tom-anders since you're the study guy you think it's cool to reopen this and for him to tweak that? |
|
Sure, but I guess it would also be fine to just open a new PR without reopening the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1392