Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for the new "hide rating except in game" option #1285

Merged
merged 9 commits into from
Dec 27, 2024

Conversation

tom-anders
Copy link
Collaborator

This adds support for the new "show ratings, except in game" option introduced in lichess-org/lila#16228

One thing that's missing now is the "explanation" for what "hide rating" means/does that was previously displayed as a subtitle - I'm not sure where the best place to display it would be now.

showRatingsExceptInGame.webm

@tom-anders tom-anders force-pushed the showRatingExceptInGame branch from 0686925 to 79c5961 Compare December 20, 2024 11:26
@veloce
Copy link
Contributor

veloce commented Dec 21, 2024

A tappable trailing "info" icon that displays the explanation in a tooltip. We once had this (or still have it?) for one setting.

@tom-anders
Copy link
Collaborator Author

A tappable trailing "info" icon that displays the explanation in a tooltip. We once had this (or still have it?) for one setting.

Ah yes, we have it for the move confirmation setting, thanks for the hint!

@utterlyrandomuser
Copy link

Hi, when selecting this option and then trying to open the preferences in the new beta mobile app it throws an error. Reverting to "Yes" por "No" and it works fine again.

@tom-anders
Copy link
Collaborator Author

Hi, when selecting this option and then trying to open the preferences in the new beta mobile app it throws an error. Reverting to "Yes" por "No" and it works fine again.

That's to be expected, this PR will fix this

@tom-anders
Copy link
Collaborator Author

Ok, added the explanation back.

@veloce Since settings are currently broken when selecting the new option (see comment by @utterlyrandomuser above, I can reproduce as well), it would probably make sense to turn this PR into a hotfix release

lib/src/view/game/archived_game_screen.dart Outdated Show resolved Hide resolved
lib/src/view/game/archived_game_screen.dart Outdated Show resolved Hide resolved
lib/src/view/game/archived_game_screen.dart Outdated Show resolved Hide resolved
lib/src/view/game/archived_game_screen.dart Outdated Show resolved Hide resolved
lib/src/view/game/game_player.dart Outdated Show resolved Hide resolved
@tom-anders tom-anders force-pushed the showRatingExceptInGame branch from 4d70e2a to bc6d636 Compare December 26, 2024 09:59
@tom-anders tom-anders force-pushed the showRatingExceptInGame branch from e76b70b to b4ebaf1 Compare December 26, 2024 21:52
Copy link
Contributor

@veloce veloce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a last change and we're good.

? const CircularProgressIndicator.adaptive()
: null,
),
child: SafeArea(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SafeArea is useless and prevents the header blur effect so it should be removed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍 Maybe it's time to do some refactoring and add a common widget for these setting choice screens? I can have a look in the next few days

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@veloce veloce merged commit b873582 into lichess-org:main Dec 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants