Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit profile page changes, closes The biography resets when reducing the keyboard #1245 #1269

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

nunibye
Copy link
Contributor

@nunibye nunibye commented Dec 17, 2024

Changes made to the edit profile page include:

  • Removed padding from top and bottom outside ListView and added padding inside ListView.
  • Added scroll behavior and GestureDetector to hide keyboard.
  • Refactored to use widgets instead of functions for performance.
  • Made screen pop on successful save.
  • trimmed all text fields before upload.
  • added PopScope to reduce accidental data loss.
    Some kind of dialog should be displayed before exiting, but that will require changing the appbar and I haven't quite figured out all the custom widgets to maintain native feel.

@veloce veloce merged commit 78bed52 into lichess-org:main Dec 17, 2024
1 check passed
@veloce
Copy link
Contributor

veloce commented Dec 17, 2024

Thanks!

I added the confirm dialog here: 6c43166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The biography resets when reducing the keyboard
2 participants