Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save streak score locally #1212

Merged
merged 1 commit into from
Dec 9, 2024
Merged

save streak score locally #1212

merged 1 commit into from
Dec 9, 2024

Conversation

tom-anders
Copy link
Collaborator

@tom-anders tom-anders commented Dec 3, 2024 •
edited
Loading

streak.webm

@tom-anders tom-anders changed the title [WIP] save streak score locally save streak score locally Dec 7, 2024
@tom-anders tom-anders marked this pull request as ready for review December 7, 2024 10:16
@tom-anders tom-anders requested a review from veloce December 7, 2024 10:16
@HaonRekcef
Copy link
Contributor

Nice work! However, the new streak in the end of the video seems to start with the same first puzzle again. I assume this is not what we want.

@tom-anders
Copy link
Collaborator Author

Nice work! However, the new streak in the end of the video seems to start with the same first puzzle again. I assume this is not what we want.

That's a server issue (or feature?) - If you fail the streak early, you sometimes get the same puzzle sequence again

veloce
veloce approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@veloce veloce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the added test!

@veloce veloce merged commit ffbe8bd into lichess-org:main Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veloce veloce veloce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tom-anders @HaonRekcef @veloce