Disable Watch tab when offline #1028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jas14
force-pushed
the
462-improve-offline-mode/disable-watch
branch
3 times, most recently
from
ecfb126 to
359eef9
Compare
jas14
force-pushed
the
462-improve-offline-mode/disable-watch
branch
from
359eef9 to
88959d1
Compare
jas14
commented
Sep 15, 2024
Comment on lines
+68
to
+73
| switch (this) { | ||
| case BottomTab.watch: | ||
| return isOnline; | ||
| default: | ||
| return true; | ||
| } |
There was a problem hiding this comment.
I suppose I could have done
return this == BottomTab.watch && isOnline;but wanted to keep the format symmetric to the other enum enhancements.
|
Thanks for this PR. I have never seen a disabled bottom tab bar button on android. So while they don't explicitly discourage doing that, I think it is better to keep the design consistent and follow iOS recommendations on all platforms. What do you think? |
|
Sounds reasonable to me, I'll see what I can do about the parts of the linked issue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small part of #462.
Android
offline.online.webm
iOS
The Cupertino design language discourages disabled buttons (Material doesn't seem to have anything against it):
So I haven't modified the iOS widgets. If we'd prefer to keep the design consistent, we can of course just close this PR, but we should update the description of #462 accordingly.