add 'add to calendar' and download ics buttons for tournament #16939
Conversation
| const title = encodeURIComponent(d.fullName); | ||
| const details = encodeURIComponent(`https://lichess.org/tournament/${d.id}`); | ||
| const startDate = new Date(d.startsAt); | ||
| const finishDate = new Date(d.finishesAt); |
There was a problem hiding this comment.
In case one would like to avoid introducing the field finishesAt in the JsonView, it could maybe be calculated instead, given the start time and the minutes field (which is the duration of the tournament in minutes) - i.e something like:
const finishDate = new Date(d.startsAt)
finishDate.setMinutes(finishDate.getMinutes() + d.minutes)There was a problem hiding this comment.
TournamentData doesn't have a minutes field though, the minutes field is in the Tournament interface which is not available in this view
|
I added a calendar-add icon using a free svg I found online, and used fontforge to add it to the sfd file. I think fontforge automatically changed some other fields of the file. Then I generated other files using licon.py. Not sure if I did everything correctly, let me know if I missed any steps. |
|
I'm not a fan. It adds code and UI complexity for something I think is extremely niche. I don't think lichess should know about outlook, yahoo and apple calendars at all. If it did, then it should apply to all dates on the site, not just tournament dates. If we produce semantically correct dates (?) then I suppose a browser extension could then take care of adding all these calendar functionalities to the date element. That's a better solution in my opinion, than to expect that all websites implement these 3rd party calendar specifics everywhere. |
resolves #5355
I added a dropdown menu for adding tournament events to calendar and downloading ics file. The menu appears in current and future tournaments.
Also added a "calendar-plus" icon for this menu.
Here's how it looks
