Make 'f' correctly toggle the orientation in a new chapter form #16904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p the editor board and not the open chapter in the background.
…ivalent to manually toggling the orientation dropdown value.
johndoknjas
changed the title
johndoknjas
changed the title
that doesn't seem useful, there's a <select> for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that pressing 'f' in a new chapter form is basically the same as the user toggling the orientation dropdown.
Note that for racing kings, pressing 'f' will toggle the orientation in the dropdown. However, it was already the case that toggling the dropdown would flip the editor's chessground board. And the actual effect on the resulting chapter board will stay the same: never being flipped initially for racing kings, irrespective of the value in the orientation dropdown. This inconsistency should probably be solved in general though, I made an issue for it a few months ago.