properly encode vapid keys #16698
Closed
properly encode vapid keys #16698
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
applicationServerKey argument to PushManager.subscribe should be Base64URL encoded (without padding)
|
Ah. So https://github.com/lichess-org/lila-push/blob/main/README.md changed and we don't want to fix up vapid externally anymore. got it. |
|
yep. i wouldn't mind the server-side conversion, but we can also just edit the config (which i had done for prod). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applicationServerKey argument to PushManager.subscribe must be Base64URL encoded (a few character substitutions and minus padding)
I have absolutely no idea why all three major browsers just started complaining about this now because the server code doesn't seem to have changed, but here we are.