Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small misc changes #16691

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Small misc changes #16691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ui/analyse/src/study/studyCtrl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ export default class StudyCtrl {
this.ctrl.flipped = this.chapterFlipMapProp(this.data.chapter.id);
if (this.members.canContribute()) this.form.openIfNew();

this.instanciateGamebookPlay();
this.instantiateGamebookPlay();

window.addEventListener('popstate', () => window.location.reload());
}
Expand Down Expand Up @@ -349,7 +349,7 @@ export default class StudyCtrl {
this.configureAnalysis();
this.vm.loading = false;

this.instanciateGamebookPlay();
this.instantiateGamebookPlay();

let nextPath: Tree.Path;

Expand Down Expand Up @@ -399,7 +399,7 @@ export default class StudyCtrl {
bottomColor = () =>
this.ctrl.flipped ? opposite(this.data.chapter.setup.orientation) : this.data.chapter.setup.orientation;

instanciateGamebookPlay = () => {
instantiateGamebookPlay = () => {
if (!this.isGamebookPlay()) return (this.gamebookPlay = undefined);
// ensure all original nodes have a gamebook entry,
// so we can differentiate original nodes from user-made ones
Expand Down Expand Up @@ -587,7 +587,7 @@ export default class StudyCtrl {
};
setGamebookOverride = (o: GamebookOverride) => {
this.vm.gamebookOverride = o;
this.instanciateGamebookPlay();
this.instantiateGamebookPlay();
this.configureAnalysis();
this.ctrl.userJump(this.ctrl.path);
if (!o) this.xhrReload();
Expand Down
2 changes: 1 addition & 1 deletion ui/game/src/view/status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export function expandFen(fullFen: FEN): string {
}

export function insufficientMaterial(variant: VariantKey, fullFen: FEN): boolean {
// TODO: atomic and antichess
// TODO: atomic, antichess, threeCheck
if (
variant === 'horde' ||
variant === 'kingOfTheHill' ||
Expand Down
Loading