Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show or Hide broadcasts results #16650

Merged
merged 43 commits into from
Jan 12, 2025
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
af4b7b7
Add a toggle to show or hide boards results
yahya-lafhal Dec 23, 2024
3754004
Show or hide results on the relayGames
yahya-lafhal Dec 23, 2024
c2b74c8
Add i18n for the showResults toggle and a basic translation
yahya-lafhal Dec 23, 2024
afc3922
Use the correct i18n
yahya-lafhal Dec 23, 2024
3ccd763
Handle css for the new toggle like the others
yahya-lafhal Dec 23, 2024
e95b256
Fix formatting
yahya-lafhal Dec 23, 2024
66caa44
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal Dec 23, 2024
195faa9
Merge branch 'master' into show-hide-broadcasts-results
ornicar Dec 24, 2024
b99ca77
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal Dec 24, 2024
53cdfb3
Merge branch 'master' into show-hide-broadcasts-results
ornicar Dec 25, 2024
a9cceb3
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal Dec 28, 2024
b6624e4
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal Dec 28, 2024
fb32e17
Merge remote-tracking branch 'fork/show-hide-broadcasts-results' into…
yahya-lafhal Dec 28, 2024
36dc823
Merge remote-tracking branch 'upstream/master' into show-hide-broadca…
yahya-lafhal Dec 28, 2024
2f764de
Remove clocks from boards grid when selecting no results
yahya-lafhal Dec 28, 2024
f2e3bb1
Hide eval gauges when hiding results
yahya-lafhal Dec 28, 2024
6ca3a48
Make the show results toggle a stored prop
yahya-lafhal Dec 28, 2024
1f92f79
Merge remote-tracking branch 'upstream/master' into show-hide-broadca…
yahya-lafhal Dec 28, 2024
426fca5
Fix formatting
yahya-lafhal Dec 28, 2024
861775f
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal Dec 28, 2024
6d63e0b
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal Dec 31, 2024
72e9f3f
Send to initial position when clicking on a broadcast game with resul…
yahya-lafhal Dec 31, 2024
5d6027f
Fix formatting
yahya-lafhal Dec 31, 2024
5507443
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal Dec 31, 2024
a9cb00b
Render empty previews with a note when setting results to off
yahya-lafhal Jan 1, 2025
e6faf8b
Fix ts formatting
yahya-lafhal Jan 1, 2025
7341cf5
Merge remote-tracking branch 'fork/show-hide-broadcasts-results' into…
yahya-lafhal Jan 1, 2025
6281168
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal Jan 1, 2025
2df749b
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal Jan 1, 2025
524d7c7
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal Jan 5, 2025
84be05c
Merge branch 'master' into show-hide-broadcasts-results
ornicar Jan 6, 2025
521bfff
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal Jan 6, 2025
52d13f5
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal Jan 7, 2025
5c5a09e
Merge branch 'master' into show-hide-broadcasts-results
ornicar Jan 7, 2025
6fcb718
redraw immediately when switching the broadcast results toggle
ornicar Jan 7, 2025
ea6002a
avoid flashing the current position when hiding the current broadcast…
ornicar Jan 7, 2025
79918a1
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal Jan 8, 2025
ec6dd8d
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal Jan 10, 2025
3286bfc
Merge branch 'master' into show-hide-broadcasts-results
ornicar Jan 12, 2025
101c13d
tweak broadcast spoiler warning
ornicar Jan 12, 2025
6a59c87
avoid flashing the first board position
ornicar Jan 12, 2025
6b28297
remove hardcoded empty board FEN
ornicar Jan 12, 2025
4e7ba07
simplify broadcast multiboard wrt results and spoilers
ornicar Jan 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ui/analyse/src/study/studyCtrl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,10 @@ export default class StudyCtrl {
return false;
}
const componentCallbacks = () => {
if (!this.multiBoard.showResults())
{
this.ctrl.userJump(this.ctrl.initialPath)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to my tests, this flashes the current position, before reverting to the initial position.

}
this.relay?.onChapterChange();
this.multiBoard.onChapterChange(this.data.chapter.id);
};
Expand Down
Loading