Support emt tag in study #15062
Support emt tag in study #15062
Conversation
lenguyenthanh
force-pushed
the
support-emt-tag-in-study
branch
from
764d9a5 to
d5b0930
Compare
lenguyenthanh
changed the title
|
Looking good 👍 At least to support it in scalachess, that way Lila has the liberty to use them as needed, even though they're not a great source of information. |
|
NVM this is Lila, not scalachess. Do you think we need to store EMT separately, instead of converting it directly to clock time? |
Oh yeah, this is a great idea saving database's field is a (probably) always good idea! |
lenguyenthanh
force-pushed
the
support-emt-tag-in-study
branch
2 times, most recently
from
b7400ac to
f9111ac
Compare
The current clock should be the previous clock (of the same color) minus emt
lenguyenthanh
force-pushed
the
support-emt-tag-in-study
branch
from
cc80dd6 to
a0d1cc4
Compare
lenguyenthanh
force-pushed
the
support-emt-tag-in-study
branch
from
92b4cca to
20fcdcc
Compare
lenguyenthanh
force-pushed
the
support-emt-tag-in-study
branch
from
6872de5 to
26929a2
Compare
lenguyenthanh
requested review from
ornicar and
kraktus
and removed request for
ornicar
| gamebook = None, | ||
| glyphs = data.metas.glyphs, | ||
| opening = None, | ||
| clock = clock.orElse((context.previousClock, emt).mapN(_ - _)), |
There was a problem hiding this comment.
What about clock increments tho? This only works for clocks like x+0.
Or do we think it's better to estimate assuming zero increment, rather than having no clock at all?
There was a problem hiding this comment.
If PGN sources specified the clock format in the PGN tags, then we could use that, but they rarely do.
* master: (59 commits) remove deps to game remove pool dep to game remove deps to game remove simul dep to game scalafmt remove opening dep to game remove deps to game lila.core.game.Game compiles lila.core.game.Game WIP lila.core.game.Game WIP scalafmt Fix HttpFilter env Disable coep:credentialless on PayPal patron page Add setting to disable site-wide coep:credentialless Cleanup Only enable site-wide coep:credentialless in Chrome 113+ Allow coep:credentialless on broadcasts with embeds eager vals, move tryDailyPuzzle to lila.puzzle.Env fix master merge fix scala syntax ...
|
better like this, than storing |
I quickly added
emtfield to study to fix #15037 and other related issues.It requires new field in database, but I guess it's fine.
Is this something We should support?
cc @kraktus @ornicar
TODO
jsonupdate api