Prohibit blocked users from posting in the comments thread of the blocker account's blog #14730
Conversation
|
Failure to block mods is fine and desired. It has to be limited to blog discussions. Even that could be a problem, I suspect. I could write a blog suggesting user X that I've blocked is a big fat doody head, then tell a bunch of lies about them in the blog discussion, and they would never be able to defend themselves. But this is wanted, so this is what they get. Good work. |
Actually mods are currently blocked from replying but I will change it.
Ok then I will limit it to only blog discussions. |
…bit admins changed in controllers.forumpost.create
|
|
|
|
An anonymous moderator would expect that they would be blocked from replying, like other users, in order to not accidentally revel themselves as having moderator powers. But that "post as a lichess moderator" would work. A public moderator would probably expect that the " Reply as a Mod " worked. ( Public means someone who has the mod badge). Regular replies are kinda 🤷 , so whatever is easiest. That's what I think anyway. I think blog authors would also expect a block to work against someone they don't know is a mod. I think it's very rare for the "comment as a mod" to be used in blog forum, so this might be overengineering things. Maybe it's better to start of treating mods and other players the same. If it turns out the function is needed, mods know how to make feature request (some would say they are too good at it 😅 ) |
|
How do I make a moderator anonymous to test this? |
|
Maybe just add a line that only shows to moderators that keep this in mind? |
|
Please just allow all posts if isGranted(_.ModerateForum), there's no reason to get fancy here. If we have a rogue moderator who is blocked and abuses their mod power to harass a blog author, we should deal with that administratively. |
Sorry for any confusion but I have not blocked the moderators from posting anything. Also I have posted the screenshot above for different cases |
I was responding to this, and conveying that I think the opposite (no restrictions on mods). I can't imagine we would have a mod replying in a blog thread of someone who has blocked them, but if it happened and the mod accidentally outed themself by posting - yeah i can see TBest's point. Of course, the user would have to put 2 and 2 together and realize that their nemesis needed mod powers to overcome the blockage. My guess is they would just consider it a bug and complain about it. |
Can you tell me why the translation doesnt work as expected? I ran bin/trans-dump and bloop clean i18n |
|
sbt clean, sbt i18n/compile, sbt bloopInstall, bloop run lila. if that doesn't fix it it's probably a typo in the keys somewhere. |
Typo is out of picture so I should try other points. |
… ublog.xml instead of site.xml
* master: (110 commits) dedup hardcoded ublog tier days Remove Tags From Video Card Info flatten blog tiers show fide federation flags on study chapter player bars add fide federation flag images list fide federations with their exotic codes study player flag based on fide id, POC only sync fide db weekly in prod new modules/player refactored away from modules/relay broadcast player name combinations: ignore single-letter words delete players who are no longer in the fide download use PGN order in broadcast team table, instead of sorting by rating fix broadcast team match on player ID or player name normalize broadcast player names during tokenization `Broadcast official` allows grouping with owned tournaments `Broadcast Official` and `Study/Broadcast Admin` permissions document broadcast player combination matching match broadcast players with name combinations New Crowdin updates (lichess-org#14747) scalachess 15.7.11 ...
Never use Option.get, it throws exceptions. Instead of checking if the value is available with Option.isEmpty, then using Option.get, you should get the value while you check for its existence.
it's usually better to resolve the option at the caller site
this is not necessary
Closes #13833