Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disproportionate /video 404 Page Layout #14262

Closed
M-DinhHoangViet opened this issue Dec 21, 2023 · 4 comments
Closed

disproportionate /video 404 Page Layout #14262

M-DinhHoangViet opened this issue Dec 21, 2023 · 4 comments

Comments

@M-DinhHoangViet
Copy link
Contributor

https://lichess.org/video/I8XaRKCAfo?
@jamesk14022
Copy link
Contributor

jamesk14022 commented Dec 21, 2023 •
edited
Loading

/tournaments and games use this 404 page, perhaps it should also be used for /video?
Screenshot 2023-12-21 at 14 16 46

@jamesk14022
Copy link
Contributor

Perhaps a better title for this issue would be "/video 404 Page Layout"

@kraktus kraktus changed the title disproportionate disproportionate /video 404 Page Layout Dec 21, 2023
@kraktus
Copy link
Member

kraktus commented Dec 21, 2023

Agreed with the title. Please always use a descriptive title that we can understand from the issue list

@cmgchess
Copy link
Contributor

a center align or a margin left should do. not sure which one suits best

ornicar added a commit to ross39/lila that referenced this issue Dec 23, 2023
@ornicar
Merge branch 'master' into qr_14173
82d413b 
* master: (206 commits)
  fix /video 404 page - closes lichess-org#14262
  Move classification flairs (fixes lichess-org#14264 ) (lichess-org#14265)
  add puzzle theme translation keys to the streak page - closes lichess-org#14273
  fix ui storage must remove the birthday key on expiration
  rename and factor ui storage birthday key
  New Crowdin updates (lichess-org#14271)
  hard coded ttl always
  remove unused function
  persistent log ws failures
  switch from xz to zstd for artifacts
  fix deploy after artifacts v4 update
  update to potentially much faster upload-artifact v4
  scala tweak, use form3.submit
  remove code duplication in ublog post ranking
  make it a bit clearer which fields are required when recomputing upost rank
  fix ublog post ranking when there is no rankAdjustDays
  don't confuse user with mod in mod log
  simplify using post.created.by
  tweak default broadcast pull periods
  recover from missing broadcast game using index.json metadata - closes lichess-org#14270
  ...
ornicar added a commit to M-DinhHoangViet/lila that referenced this issue Dec 23, 2023
@ornicar
Merge branch 'master' into more-trans-on-blog-page
5afc0bf 
* master: (43 commits)
  simplify and redesign challenge page QR code
  fix /video 404 page - closes lichess-org#14262
  Move classification flairs (fixes lichess-org#14264 ) (lichess-org#14265)
  add puzzle theme translation keys to the streak page - closes lichess-org#14273
  fix ui storage must remove the birthday key on expiration
  rename and factor ui storage birthday key
  New Crowdin updates (lichess-org#14271)
  hard coded ttl always
  remove unused function
  persistent log ws failures
  switch from xz to zstd for artifacts
  fix deploy after artifacts v4 update
  update to potentially much faster upload-artifact v4
  scala tweak, use form3.submit
  remove code duplication in ublog post ranking
  make it a bit clearer which fields are required when recomputing upost rank
  fix ublog post ranking when there is no rankAdjustDays
  don't confuse user with mod in mod log
  simplify using post.created.by
  tweak default broadcast pull periods
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jamesk14022 @kraktus @cmgchess @M-DinhHoangViet