ui/learn remove asumption of surrounding #main-wrap

and apply the zindex setting during chessground creation
lichess-org · Dec 30, 2024 · 129d188 · 129d188
1 parent 5267349
commit 129d188
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/modules/web/src/main/ui/LearnUi.scala b/modules/web/src/main/ui/LearnUi.scala
@@ -20,7 +20,8 @@ final class LearnUi(helpers: Helpers):
             "data" -> data,
             "pref" -> Json.obj(
               "coords"      -> ctx.pref.coords,
-              "destination" -> ctx.pref.destination
+              "destination" -> ctx.pref.destination,
+              "is3d"        -> ctx.pref.is3d
             )
           )
         )

diff --git a/ui/learn/src/chessground.ts b/ui/learn/src/chessground.ts
@@ -36,4 +36,5 @@ const makeConfig = (ctrl: RunCtrl): CgConfig => ({
   drawable: { enabled: false },
   draggable: { enabled: true },
   selectable: { enabled: true },
+  addPieceZIndex: ctrl.pref.is3d,
 });
diff --git a/ui/learn/src/learn.ts b/ui/learn/src/learn.ts
@@ -35,6 +35,7 @@ export interface LearnOpts {
 export interface LearnPrefs {
   coords: Coords;
   destination: boolean;
+  is3d: boolean;
 }
 
 interface LearnServerOpts {

diff --git a/ui/learn/src/run/runCtrl.ts b/ui/learn/src/run/runCtrl.ts
@@ -69,8 +69,6 @@ export class RunCtrl {
 
   setChessground = (chessground: CgApi) => {
     this.chessground = chessground;
-    this.chessground.state.addPieceZIndex =
-      document.querySelector('#main-wrap')?.classList.contains('is3d') ?? false;
     this.withGround(this.levelCtrl.initializeWithGround);
   };