Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add services after setup has already been completed #95

Merged
merged 9 commits into from
Jun 15, 2024

Conversation

Carbrex
Copy link
Member

@Carbrex Carbrex commented Jun 14, 2024

Closes #47
New services can now be added without ./lila-docker down.
Do ./lila-docker add-services to add new services, then select the new services you want to add.
Only the new ones among the selected services will be added.

Try on gitpod: https://gitpod.io/new/#https://github.com/Carbrex/lila-docker/tree/add-services-after-setup

@Carbrex Carbrex marked this pull request as draft June 14, 2024 12:16
@Carbrex Carbrex marked this pull request as ready for review June 14, 2024 12:30
@Carbrex
Copy link
Member Author

Carbrex commented Jun 14, 2024

These 2 tests

test tests::test_gitpod_lila_url ... FAILED
test tests::test_gitpod_lila_url_with_pr_context ... FAILED

sometimes fail randomly and sometimes pass when I run cargo test locally.

@Carbrex
Copy link
Member Author

Carbrex commented Jun 14, 2024

Nvm, they fail as they run concurrently, cargo test -- --test-threads=1 works fine.

@fitztrev
Copy link
Member

Just tried it, looks great! Will test more later.

I wonder if it should still prompt for database setup. If search for instance is added, may need to re-run the seeder to populate elasticsearch.

@Carbrex Carbrex force-pushed the add-services-after-setup branch from bf4676c to e96afd4 Compare June 14, 2024 14:27
@fitztrev fitztrev merged commit be5ec34 into lichess-org:main Jun 15, 2024
2 checks passed
@Carbrex Carbrex deleted the add-services-after-setup branch August 4, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to add services after setup has already been completed
2 participants