Reduce image size with multi-stage build #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an example "refactoring" of the
ci.Dockerfile,which reduces the size from 3 GB to 2 GB.
At least the integration tests in chariot are still passing,
but that should probably not be "the one source of truth" if this refactoring is sound or not 😀
I think the main things which is gotten rid of with this updated image are "leftovers" from sbt and git checkouts.
I'm not confident in that I know which files from the lila git checkout that are needed in actual runtime - but the current copying of
seems to work so far...