-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made an attempt to make docker images lighter. #68
Conversation
Looking great, thanks! Yeah if you want to split out the updates to the node-based images, those could be merged. |
I think the only node based image is the |
…stage to reduce size
Reduced the size of picfit image in this commit but the image build process downloads 1GB data. So, I uploaded this image on docker and now the build time is reduced pretty much. Either we can use it carbrex/thoas-picfit:latest as it is or upload on docker hub under lichess and then use it?
|
@Carbrex it looks like |
Yes, I saw that but it only supports arm for now. I have filed an issue on github, we can wait for it to get resolved. thoas/picfit#192 |
I'm OK to merge now if it's ready? We can use your hosted image for now. At some point maybe we can move it to be hosted by ghcr, like I'm doing with #62 |
Its ready. |
Nice improvement, thanks! |
I have made changes to some docker files to reduce their size.
You dont need to merge this. I was just trying to reduce the size you can incorporate the changes you want.
These are the comparisons before and after changes:
Before changes:
docker images
docker stats
After changes:
docker images
docker stats
To make an sbt image for alpine I took this https://github.com/buildo/scala-sbt-alpine/blob/master/Dockerfile and made some changes to this. It works just fine and lila and lila-fishnet work fine too.
I think the ui.Dockerfile can be taken as it is. It works well with chessground and pgn-viewer also.