Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make database available outside of the container #36

Closed
wants to merge 1 commit into from

Conversation

Juesto
Copy link
Contributor

@Juesto Juesto commented Nov 29, 2023

this would have the benefit of keeping the database data when running ./lila-docker down and bringing it back up due to the need of changing optional components and such

@fitztrev
Copy link
Member

fitztrev commented Dec 5, 2023

Thanks, I think we'll make this opt-in. I prefer the behavior of the database getting reset after running ./lila-docker down but I can see cases where it might be beneficial or if people have a different preference. Could you add it to the docs/README instead? Also, you can add the database folder to gitignore so that's already set when people use it.

@Juesto
Copy link
Contributor Author

Juesto commented Dec 5, 2023

sure! issuing the docker cp command will automatically create the volume for people so maybe be clear with that, no promises but i'll get around putting it into the readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants