Fix timeline XSS #2230
Merged
Fix timeline XSS #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
niklasf
added a commit
to lichess-org/lila
that referenced
this pull request
Nov 10, 2022
ornicar
added a commit
to lichess-org/lila
that referenced
this pull request
Nov 23, 2022
prepare bringing back mobile timeline after lichess-org/lichobile#2230
RoepStoep
pushed a commit
to RoepStoep/lidraughts
that referenced
this pull request
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2212 . Tested by mocking out the xhr.ts
timelinefunction to return one of each type of timeline entry with HTML in the data.Also fixes 63 lint warnings in 9c6a40f. If this is too large of a change, I'm happy to revert that commit.
Before
npm run lintresults:After
npm run lintresults: