Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store chat messages #1084

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AttackingOrDefending
Copy link
Member

Type of pull request:

  • Bug fix
  • Feature
  • Other

Description:

Stores chat messages for the duration of the game to allow users to build more complicated chat mechanisms (e.g. letting people vote the result of the game, and after the end saying something depending on the votes).

Related Issues:

None

Checklist:

  • I have read and followed the contribution guidelines.
  • I have added necessary documentation (if applicable).
  • The changes pass all existing tests.

Screenshots/logs (if applicable):

@MarkZH
Copy link
Collaborator

MarkZH commented Feb 1, 2025

How do users access the messages? Would they need to modify a fork of the code?

@AttackingOrDefending
Copy link
Member Author

They would need to add custom code in react in conversation.py. Perhaps this can become more generalized to make it easier to add custom commands, but I wan't sure how I should do it.

@MarkZH
Copy link
Collaborator

MarkZH commented Feb 1, 2025

Yeah, it's difficult to know how to create new features without a use case. Was there a request for something like this on discord or elsewhere?

@AttackingOrDefending
Copy link
Member Author

No. I just thought it would be nice to let people build their own chatters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants