Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing details regarding the data format #72

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

janstarke
Copy link

  • checksum: I found the value you specified is not the starting value for checksum calculation. However, it seems that the starting value you gave is exactly the magic number "\xef\xcd\xab\x89". So, if you start at byte offset 4, using this starting value, it gets nulled out when XORing with the magic number. So, either you start with offset 4 using the starting value you supplied ((which is what you are doing;
    if( libesedb_checksum_calculate_little_endian_xor32(
    &calculated_xor32_checksum,
    &( data[ 4 ] ),
    data_size - 4,
    0x89abcdef,
    error ) != 1 )
    )), or you start at offset 8 with no starting value.
  • DBTIME: I found in my test data that the structure contains three 1-byte-values (which follow your assertions and do look like a time), followed by 5 NULL-bytes.

- checksum: I found the value you specified is *not* the starting value for checksum calculation. However, it seems that the starting value you gave is exactly the magic number `"\xef\xcd\xab\x89"`. So, if you start at byte offset 4, using this starting value, it gets nulled out when XORing with the magic number. So, either you start with offset `4` using the starting value you supplied ((which is what you are doing; https://github.com/libyal/libesedb/blob/d959e1e037635c72f07f08e2ac741036268f4e3c/libesedb/libesedb_file_header.c#L678-L683)), or you start at offset `8` with no starting value.
- DBTIME: I found in my test data that the structure contains three 1-byte-values (which follow your assertions and do look like a time), followed by 5 NULL-bytes.
Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.83%. Comparing base (d959e1e) to head (8c57e22).

❗ There is a different number of reports uploaded between BASE (d959e1e) and HEAD (8c57e22). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (d959e1e) HEAD (8c57e22)
4 2
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   22.19%   16.83%   -5.37%     
==========================================
  Files          53       53              
  Lines       12299    12296       -3     
  Branches     2843     2842       -1     
==========================================
- Hits         2730     2070     -660     
- Misses       9141     9894     +753     
+ Partials      428      332      -96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant