refactor(StackInfo): rename StackInfo.cpp to StackInfoImpl.cpp and si…

…mplify decodeSymbolName method
libsese · Jan 8, 2025 · bcfc1fd · bcfc1fd
1 parent f00620e
commit bcfc1fd
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/sese/native/darwin/system/StackInfo.cpp → .../internal/darwin/system/StackInfoImpl.cpp b/sese/native/darwin/system/StackInfo.cpp → .../internal/darwin/system/StackInfoImpl.cpp
diff --git a/sese/native/linux/system/StackInfo.cpp → sese/internal/linux/system/StackInfoImpl.cpp b/sese/native/linux/system/StackInfo.cpp → sese/internal/linux/system/StackInfoImpl.cpp
diff --git a/sese/native/unix/system/StackInfo.cpp → sese/internal/unix/system/StackInfoImpl.cpp b/sese/native/unix/system/StackInfo.cpp → sese/internal/unix/system/StackInfoImpl.cpp
diff --git a/sese/native/win/system/StackInfo.cpp → sese/internal/win/system/StackInfoImpl.cpp b/sese/native/win/system/StackInfo.cpp → sese/internal/win/system/StackInfoImpl.cpp
@@ -53,7 +53,6 @@ std::string system::StackInfo::decodeSymbolName(const std::string &str) noexcept
     auto pos = str.find_first_of('<');
     if (pos == std::string::npos) {
         return str;
-    } else {
-        return str.substr(0, pos);
     }
+    return str.substr(0, pos);
 }
diff --git a/sese/system/StackInfo.h b/sese/system/StackInfo.h
@@ -36,7 +36,7 @@ struct SubStackInfo {
 };
 
 /// Stack Information
-class StackInfo {
+class StackInfo final {
 public:
     /// Create a container to store the current stack information
     /// \param limit Stack depth limit
@@ -53,7 +53,11 @@ class StackInfo {
     static uint16_t offset;
 
 protected:
-    /// This function is used to remove template parameter information on Windows, and to decode symbol names on other systems
+    /// \brief Decode symbol name
+    /// \details This function is used to remove template parameter information on Windows,
+    /// and to decode symbol names on other systems.
+    /// \param str Symbol name
+    /// \return Decoded symbol name
     static std::string decodeSymbolName(const std::string &str) noexcept;
 
     std::vector<SubStackInfo> stacks;