Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SchreierSims for v1 #200

Merged
merged 18 commits into from
Nov 21, 2024

Conversation

Joseph-Edwards
Copy link
Collaborator

@Joseph-Edwards Joseph-Edwards commented Nov 8, 2024

This PR adds the SchreierSims class and associated helpers in advance of the v1 release. Supersedes #109.

TODO

  • Add the bindings to the cpp file;
  • Expose the functionality in libsemigoups_pybind11;
  • Add the the pages to the doc;
  • Wrap the class in a Python class (after Update froidure-pin-hpp for v1/3 #197 is merged);
  • Format the documentation and the signatures;
  • Add tests.

@james-d-mitchell james-d-mitchell added the v1 Label for issues/prs for v1 label Nov 12, 2024
@Joseph-Edwards Joseph-Edwards marked this pull request as ready for review November 21, 2024 11:52
@Joseph-Edwards
Copy link
Collaborator Author

Joseph-Edwards commented Nov 21, 2024

The macOS tests are failing because SchreierSims and FroidurePin have identical constructors. @james-d-mitchell, do you think we should edit these classes to inherit from a common InitFromGenerators abstract base class, or just suppress the warning?

@james-d-mitchell
Copy link
Member

The macOS tests are failing because SchreierSims and FroidurePin have identical constructors. @james-d-mitchell, do you think we should edit these classes to inherit from a common InitFromGenerators abstract base class, or just suppress the warning?

Maybe simplest to just add a TODO to do that later and to disable the linting error for now

@james-d-mitchell james-d-mitchell merged commit 96a1f5c into libsemigroups:v1 Nov 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1 Label for issues/prs for v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants