Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the autodoc directive to improve overloaded functions #160

Merged
merged 5 commits into from
Apr 26, 2024

Conversation

Joseph-Edwards
Copy link
Collaborator

This PR improves how overloaded functions get rendered in the documentation. Specifically, it formats them in the same that non-overloaded functions get formatted, and adds a level of indentation.

I decided to use this directive to override the standard autoclass and autofunction directives, since it provides a superset of their functionality. The only downside that I can see is that this causes a directive already registered warning. If this is undesirable I can call it something else.

@Joseph-Edwards
Copy link
Collaborator Author

I've just noticed a few problems with this, specifically with automodule. Fixing them now.

@james-d-mitchell
Copy link
Member

@Joseph-Edwards looks good, but needs to be rebased please

@james-d-mitchell james-d-mitchell added documentation Improvements or additions to documentation v1 Label for issues/prs for v1 labels Apr 26, 2024
@james-d-mitchell james-d-mitchell merged commit a6e5fe7 into libsemigroups:v1 Apr 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation v1 Label for issues/prs for v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants