Foundations for v1 release #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent, I think we expect the ci to fail at this point, amIright? |
|
We would expect the ci to fail, since very few of the test files have been updated. However, some of the issues seem to be with installing the requirements, so I'll look into that. One of the jobs uses Python 3.7 which is too low. We should decide what we want our minimum requirement to be. |
|
Might be a good to also get the CI to pass (i.e. temporarily remove the "should be" failing test files). |
Joseph-Edwards
force-pushed
the
v1
branch
2 times, most recently
from
feeffaa to
546c5d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains some initial changes made to the bindings in preparation for the release of
libsemigroupsv3. Most of these changes are related to theKnuthBendixclass and the docs.