Mouse coordinates are floating point #6950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericwa, can you take a look at this? |
slouken
force-pushed
the
highdpi-mouse
branch
4 times, most recently
from
976fa3e to
37fe532
Compare
You can get sub-pixel mouse coordinates and motion depending on the platform and display scaling. Fixes libsdl-org#2999
slouken
force-pushed
the
highdpi-mouse
branch
from
1f63567 to
78075c2
Compare
slouken
force-pushed
the
highdpi-mouse
branch
3 times, most recently
from
a10efdf to
0f2ba1e
Compare
This function is useful for accumulating relative mouse motion if you want to only handle whole pixel movement.
e.g.
static float dx_frac, dy_frac;
float dx, dy;
/* Accumulate new motion with previous sub-pixel motion */
dx = event.motion.xrel + dx_frac;
dy = event.motion.yrel + dy_frac;
/* Split the integral and fractional motion, dx and dy will contain whole pixel deltas */
dx_frac = SDL_modff(dx, &dx);
dy_frac = SDL_modff(dy, &dy);
if (dx != 0.0f || dy != 0.0f) {
...
}
slouken
force-pushed
the
highdpi-mouse
branch
from
0f2ba1e to
86cdbc5
Compare
|
Sure. I did a bit of testing with
All looks good so far |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can get sub-pixel mouse coordinates and motion depending on the platform and display scaling.
Fixes #2999