Remove redundant sizeof "size_t" check #4676
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result variables: HAVE_${VARIABLE}, ${VARIABLE}, ${VARIABLE}_CODE, etc. do not seem to be referenced anywhere in the CMake build script. Unless I was mistaken on how the check is being used.
The motivation for me to have the redundant check removed is because otherwise it would cause an error in my SDL initial build tree generation with my own custom
Emscripten.cmake
toolchain file. My custom CMake toolchain file is much simpler version than the official one provided by EMSDK, which does not provide the "hack" version of theCheckTypeSize.cmake
.But in any case, there should be no harm to have this redundant check removed for other use cases.
My Web CI build can be found here: https://github.com/alpha-scorpii-b/SDL/runs/3383479743?check_suite_focus=true