In x11, GetDisplayDPI can give incorrect or unusable DPI information.… #4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Using XGetDefaults to get the Xft DPI if it's available and returning that. This could allow you to figure out DPI scale.
JayFoxRox
reviewed
May 8, 2021
… without having to do an unnecessary conversion. Then do explicit conversions later on if we need.
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding call to X11 XGetDefault to retrieve the xft dpi and using that as the dpi value if it's available.
Description
The X11 implementation of GetDisplayDPI currently returns the physical dpi and in some cases the incorrect dpi. This happens if the xrandr extension is used. Using XGetDefault will give us the xft dpi when available which is the useful virtual dpi and would allow users to determine what the scale factor is and possibly use features like hidpi.
Existing Issue(s)
This could be helpful for issues such as #4176