Turned on compiler warnings and fixed the associated issues.

libscran · Jun 25, 2024 · 7a2665c · 7a2665c
1 parent 8bd08d4
commit 7a2665c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/include/scran/block_weights.hpp b/include/scran/block_weights.hpp
@@ -36,7 +36,7 @@ struct VariableParameters {
      * @param u Upper bound for the block weight calculation, should be not less than `l`.
      * This should be greater than `l`.
      */
-    constexpr VariableParameters(double l = 0, double u = 1000) : upper_bound(u), lower_bound(l) {}
+    constexpr VariableParameters(double l = 0, double u = 1000) : lower_bound(l), upper_bound(u) {}
 
     /**
      * Lower bound for the block weight calculation.

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
@@ -39,6 +39,8 @@ macro(create_test name)
         scran_test_utils
     )
 
+    target_compile_options(${name} PRIVATE -Wall -Werror -Wpedantic -Wextra)
+
     if(DO_CODE_COVERAGE)
         target_compile_options(${name} PRIVATE -O0 -g --coverage)
         target_link_options(${name} PRIVATE --coverage)