Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lxlquery): Allow groups in boolean query #1188

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix(lxlquery): Allow groups in boolean query #1188

merged 1 commit into from
Dec 12, 2024

Conversation

jesperengstrom
Copy link
Contributor

@jesperengstrom jesperengstrom commented Dec 11, 2024 •
edited
Loading

Description

Solves

A BooleanQuery can contain Group, which we did not specify in the grammar.

Skärmavbild 2024-12-11 kl 14 51 32 Skärmavbild 2024-12-11 kl 14 50 31

Summary of changes

  • Addition to lxlquery grammar
  • Add a test

@jesperengstrom jesperengstrom marked this pull request as ready for review December 11, 2024 13:58
johanbissemattsson
johanbissemattsson approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@johanbissemattsson johanbissemattsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@jesperengstrom jesperengstrom merged commit f2e112a into develop Dec 12, 2024
3 checks passed
@jesperengstrom jesperengstrom deleted the fix/lxlquery-add-group-to-booleanquery branch December 12, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbissemattsson johanbissemattsson johanbissemattsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesperengstrom @johanbissemattsson