-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LWS-263: Supersearch pills #1176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesperengstrom
force-pushed
the
feature/LWS-263-supersearch-pills-2
branch
from
November 25, 2024 11:55
e3736d7
to
59b8308
Compare
jesperengstrom
changed the title
LWS-263: Supersearch pills (2)
LWS-263: Supersearch pills
Nov 25, 2024
jesperengstrom
force-pushed
the
feature/LWS-263-supersearch-pills-2
branch
from
November 26, 2024 14:45
6320ec8
to
55d16ef
Compare
Aims to clarify connection with Libris XL
Imports from '$app/stores' are SvelteKit-specific imports which would require @sveltejs/kit to be added as a peer-dependency, resulting in larger bundle-sizes for non-svelte implementations.
johanbissemattsson
approved these changes
Nov 28, 2024
…s-2-adjustments LWS-263: Supersearch pills adjustments/suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tickets involved
LWS-263
Solves
Adds qualifier pills in the CM editor based on lxlQuery syntax tree
Summary of changes
extension/qualfierPlugin.ts
and add toSuperSearch
..qualifier
element.QualifierRemove
(not really working atm!)QualifierKey
.qualifierValue
s.EqualOperator
andCompareOperator
withQualifierOperator
to make sure it's always present. Update tests, tags, classes & style accordingly.BooleanOperator
to avoid it being highlighted outside of a legal query.