Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWS-263: Supersearch pills #1176

Merged
merged 31 commits into from
Nov 28, 2024
Merged

Conversation

jesperengstrom
Copy link
Contributor

@jesperengstrom jesperengstrom commented Nov 25, 2024

Description

Tickets involved

LWS-263

Solves

Adds qualifier pills in the CM editor based on lxlQuery syntax tree

Summary of changes

  • Create extension/qualfierPlugin.ts and add to SuperSearch.
  • The plugin consists of:
    • A mark decorator that creates a wrapper .qualifier element.
    • A widget decorator that adds a remove link/button using new svelte component QualifierRemove (not really working atm!)
    • A replace decorator that replaces the qualifier key/operator with new svelte component QualifierKey.
    • Two bundled extensions that adds atomic ranges and inserts a quote for empty qualifierValues.
  • Language changes:
    • Replace nodes EqualOperator and CompareOperator with QualifierOperator to make sure it's always present. Update tests, tags, classes & style accordingly.
    • Don't export BooleanOperator to avoid it being highlighted outside of a legal query.

@jesperengstrom jesperengstrom force-pushed the feature/LWS-263-supersearch-pills-2 branch from e3736d7 to 59b8308 Compare November 25, 2024 11:55
@jesperengstrom jesperengstrom changed the title LWS-263: Supersearch pills (2) LWS-263: Supersearch pills Nov 25, 2024
@jesperengstrom jesperengstrom marked this pull request as ready for review November 25, 2024 12:53
@jesperengstrom jesperengstrom force-pushed the feature/LWS-263-supersearch-pills-2 branch from 6320ec8 to 55d16ef Compare November 26, 2024 14:45
johanbissemattsson and others added 2 commits November 28, 2024 15:53
…s-2-adjustments

LWS-263: Supersearch pills adjustments/suggestions
We will ha to revisit this again...
@jesperengstrom jesperengstrom merged commit bf186fb into develop Nov 28, 2024
4 checks passed
@jesperengstrom jesperengstrom deleted the feature/LWS-263-supersearch-pills-2 branch November 28, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants