feat(supersearch): Improved handling of double-click and triple-click for text selection #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… text selection Removes the need of a delay before showing the dialog element
johanbissemattsson
added a commit
that referenced
this pull request
Nov 19, 2024
If the expanded search text box is placed at the same place as the collapsed, text-selection by double-clicking and triple-clicking will work mostly natively out-of-the-box. If we decide that we need to support cases where the expanded search text box is placed somewhere else then #1171 can be merged.
|
I think we should keep this PR unmerged for now to keep the code as simple as possible (If the expanded search text field is placed at the same place as the collapsed, text-selection by double-clicking and triple-clicking will work mostly natively out-of-the-box). We can merge it if we decide that we need to support cases where the expanded search text box is placed somewhere else. |
|
Closing for now, we can re-open it later if we decide that we need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tickets involved
LWS-267
Solves
Improves the handling of text-selection when double-clicking and triple-clicking on text in the collapsed editor.
Double-clicks results in the selection of the word at the given position while triple-clicks selects the entire line.
Summary of changes