-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LWS-143: Related hits search #1059
Conversation
bed3398
to
a636f26
Compare
a636f26
to
42e394a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the front-end implementation looks good but I'm a little unsure about the user experience as the search doesn't always give relevant hits.
An example:
- Go to http://localhost:5173/75kmmbnr2xl0fn5
- Try searching for
kam
in the related search input - No results are found (I would atleast expect Kamrater på en irrande planet to appear)
I'm not sure everyone would expect that. |
Aha! That explains it. Then it's out of scope of this PR but I think it's good to discuss it further in another context. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll merge this as is and postpone fixing the cleared filters a bit.
Description
Tickets involved
LWS-143
Solves
Adds a search input in the toolbar section for the related search result
Summary of changes
SearchRelated
that searches in the context of the current_o
and_p
.Limits/todos:
_q
param in a safe way. If we need to keep the filters, maybe template links (such as in year range) could be a solution.