-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LWS-313: Yet another pagination bugfix #1057
LWS-313: Yet another pagination bugfix #1057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lxl-web/src/routes/(app)/[[lang=lang]]/(find)/Pagination.svelte
Outdated
Show resolved
Hide resolved
lxl-web/src/routes/(app)/[[lang=lang]]/(find)/Pagination.svelte
Outdated
Show resolved
Hide resolved
There is still some reactivity issues regarding the number of pagination items. To reproduce:
|
Good call. Extended the sequence to 8, let's see what happens when moving on to the styling issues... |
Added:
Suggest we save mobile improvements for later |
e56a4cd
to
5520008
Compare
1bd8698
to
9abe2eb
Compare
Description
Tickets involved
LWS-131
Solves
Paginating the relation search does not work in some cases.
Because: simply appending
_offset
to the link causes a new double-fetch (introduced with the predicate tabs) that ultimately uses the predicateview
to get the data. That link excludes any applied_offset
, fetching the first 10 hits again.By using a backend-made link as template for all pagination links, we avoid the problem (and double fetch) since they include the
_p
param.Summary of changes