Feature/oaipmh without dep max modified #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sets without depMaxModified.
olovy
approved these changes
Jan 24, 2020
There was a problem hiding this comment.
Looks good!
The only problem I see (which existed before) is that the request holds a database connection while calling into loadEmbellished, followDependers, getAttachedHoldings etc. risking connection grabbing deadlocks. (this is because of two changes: setting connectionpool size to a small value and infinite connection timeouts).
The only sane solution I see is to have a separate connection pool for the API? (initialized by PostGreSQLComponent). We could do this as a separate feature branch.
|
|
||
| public class Helpers | ||
| { | ||
| public static class ResultIterator implements Iterator<Document>, AutoCloseable { |
| for (Tuple2<String, String> depender : dependers) | ||
| { | ||
| String dependerId = depender.getFirst(); | ||
| Document dependerDocument = OaiPmh.s_whelk.loadEmbellished(dependerId); |
There was a problem hiding this comment.
Should this be getDocument()? (embellish is done in ResponseCommon.emitRecord())
There was a problem hiding this comment.
Good catch! Fixing it!
olovy
pushed a commit
that referenced
this pull request
Feb 3, 2020
* Make emitRecord take Documents instead of sql resultsets. * Make both from and until optional again. * Make the adhoc tests at least possibly reusable.
olovy
added a commit
that referenced
this pull request
Feb 3, 2020
* Make emitRecord take Documents instead of sql resultsets. * Make both from and until optional again. * Make the adhoc tests at least possibly reusable. Co-authored-by: Jannis Mohlin Tsiroyannis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares for removing the depMaxModified column, as it removes its only use (which is in OAIPMH).
It does not (yet) remove the updating of depMaxModified (which is the real win). It only removes the need for it.