boostedfields for query #1510
Closed
boostedfields for query #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwahlin
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Most of the stuff in BoostedFields is redundant, see EsMappings.
I suggest letting QueryParams handle the parameters and move the boost computing stuff into QueryUtil (where all that is needed should be available).
|
new version... |
kwahlin
reviewed
Nov 25, 2024
|
|
||
| Map<String, String[]> queryParameters = new HashMap<>(ogQueryParameters); | ||
|
|
||
| String[] originalTypeParam = queryParameters.get("@type"); |
There was a problem hiding this comment.
This won't work in the new style API since we don't put properties as separate parameters. Instead we have to extract the type from the query tree that get from _q (+applied filters).
|
Completed in #1531 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative attempt at boosting fields.