Replace checkout action, remove upload #17214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to node v20 being incompatible with some of the CI images (too old glibc), the checkout action is replaced by an alternative which does not need node, and upload is removed for now.
|
I guess this is a good stop-gap for now, it beats all CI jobs failing right now. I guess later on you can send further PRs to improve upon it. We could also discuss it further in DM if you'd like. |
|
Woops, while this fixes the CI jobs on github, it seems to break the gitlab CI. So I'll have to revert it for now. |
|
Here is the error - https://git.libretro.com/libretro/RetroArch/-/pipelines/317183 You can submit a new version that hopefully doesn't have this error later on. |
LibretroAdmin
added a commit
that referenced
this pull request
Nov 26, 2024
This reverts commit 04b53ce.
LibretroAdmin
added a commit
that referenced
this pull request
Nov 26, 2024
|
F... Sorry. I did not mean to push the gitlab-ci changes, as they were part of an irrelevant test, but the late-evening rebase did not go as smoothly as it looked. |
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
Due to node v20 being incompatible with some of the CI images (too old glibc), the checkout action is replaced by an alternative which does not need node, and upload is removed for now.
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
…retro#17215) This reverts commit 04b53ce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to node v20 being incompatible with some of the CI images (too old glibc), the checkout action is replaced by an alternative which does not need node. Upload is removed, I did not find a straightforward replacement right now.
Not quite sure this is the best approach, but it is here anyways as a stop-gap, and it does produce green builds. Needless to say, this change also does not address any of the issues that were discussed on RA Discord
#programmingchannel (bandwidth, job maintenance, etc.).