Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix normalized DN attribute escaping #71

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Conversation

rhafer
Copy link
Collaborator

@rhafer rhafer commented Jul 13, 2022

Apply the DN escaping rules on the normalized DN parts when
turning a DN into a normalized string form

Fixes: #70

Apply the DN escaping rules on the normalized DN parts when
turning a DN into a normalized string form

Fixes: libregraph#70
@rhafer rhafer self-assigned this Jul 13, 2022
@rhafer
Copy link
Collaborator Author

rhafer commented Jul 13, 2022

Note: Ideally this some of this code should be part of go-ldap/ldap/v3. I am trying to revive the related PR there in parallel. But I'd like to get it in here in order to unblock some related work. (Will rework the code again if the upstream effort takes any fruit)

@rhafer rhafer requested a review from longsleep July 13, 2022 12:29
Copy link
Collaborator

@longsleep longsleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhafer rhafer merged commit 419a21f into libregraph:master Jul 13, 2022
@rhafer rhafer deleted the issue70 branch July 13, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DN normalization doesn't correctly re-escape attribute values
2 participants