Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compile.m to fix https://github.com/libprima/prima/issues/161 #162

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

zaikunzhang
Copy link
Member

This is a workaround for #161, where MEX fails due to incompatibility between the new linker of Xcode 15 on macOS and Intel oneAPI 2023. The fix is to replace the linker option "-undefined error" with "-undefined dynamic_lookup". See also #158. Note that we have to modify LDFLAGSVER. Setting LDFLAGS or LINKFLAGS does not work, although the latter is suggested at https://www.mathworks.com/help/matlab/ref/mex.html.

This is a workaround for #161, where MEX fails due to incompatibility between the new linker of Xcode 15 on macOS and Intel oneAPI 2023.  The fix is to replace the linker option "-undefined error" with "-undefined dynamic_lookup". See also #158. Note that we have to modify `LDFLAGSVER`. Setting `LDFLAGS` or `LINKFLAGS` does not work, although the latter is suggested at https://www.mathworks.com/help/matlab/ref/mex.html.
% where MEX fails due to incompatibility between the new linker of Xcode 15 on macOS and Intel oneAPI 2023.
% The fix is to replace the linker option "-undefined error" with "-undefined dynamic_lookup".
% See also https://github.com/libprima/prima/issues/158.
% Note that we have to modify `LDFLAGSVER`. Setting `LDFLAGS` or `LINKFLAGS` does not work, although

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

LDFLAGSVER is not a recognized word. (unrecognized-spelling)
% where MEX fails due to incompatibility between the new linker of Xcode 15 on macOS and Intel oneAPI 2023.
% The fix is to replace the linker option "-undefined error" with "-undefined dynamic_lookup".
% See also https://github.com/libprima/prima/issues/158.
% Note that we have to modify `LDFLAGSVER`. Setting `LDFLAGS` or `LINKFLAGS` does not work, although

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

LINKFLAGS is not a recognized word. (unrecognized-spelling)
% the latter is suggested at https://www.mathworks.com/help/matlab/ref/mex.html.
linker_options = '';
if ismac && contains(compiler_configurations.Manufacturer, 'intel', 'IgnoreCase', true) % macOS with Intel compiler
linker_options = 'LDFLAGSVER=$(echo $LDFLAGSVER | sed "s/-undefined error/-undefined dynamic_lookup/g")';

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

LDFLAGSVER is not a recognized word. (unrecognized-spelling)
% the latter is suggested at https://www.mathworks.com/help/matlab/ref/mex.html.
linker_options = '';
if ismac && contains(compiler_configurations.Manufacturer, 'intel', 'IgnoreCase', true) % macOS with Intel compiler
linker_options = 'LDFLAGSVER=$(echo $LDFLAGSVER | sed "s/-undefined error/-undefined dynamic_lookup/g")';

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

LDFLAGSVER is not a recognized word. (unrecognized-spelling)
@zaikunzhang zaikunzhang changed the title Update compile.m to fixhttps://github.com/libprima/prima/issues/161 Update compile.m to fix https://github.com/libprima/prima/issues/161 Feb 16, 2024
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (2)

LDFLAGSVER
LINKFLAGS

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:libprima/prima.git repository
on the zaikunzhang-fix-macos-13-mex-failure branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/libprima/prima/actions/runs/7933597922/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@zaikunzhang zaikunzhang merged commit 80d7c2f into main Feb 16, 2024
74 checks passed
@zaikunzhang zaikunzhang deleted the zaikunzhang-fix-macos-13-mex-failure branch February 16, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant