add working ping test (js) or multidim-interop #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarcoPolo this PR is ready for review what is me concerned. |
MarcoPolo
force-pushed
the
patch/wo-testground-libp2p-js
branch
from
42fbfc8 to
9e8dc76
Compare
MarcoPolo
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Some small comments. Looks great! I'll merge this soon.
In the mean time, please start the browser version. I'm imagining this will be almost identical to this node version, except once you have the listener addr, you start the playwright instance and connect.
|
Super happy to see this happen! The code looks really clean and straightforward, which is a big plus for the wo-testground architecture. |
MarcoPolo
force-pushed
the
patch/wo-testground-libp2p-js
branch
from
d283cd5 to
0a3275f
Compare
|
Merging this now, then merging #97 when CI passes :) |
MarcoPolo
added a commit
that referenced
this pull request
Jan 10, 2023
* Add fast multidimensional interop tests * Remove generated files * Remove debug code around itnerfaces * Revert changes to setup testground * multidim-interop: update rust v050 test for multidim-interop with redis * Add depends on and enable rust version for testing * Cleanup Rust test * Have listener print multiaddr in go v024 test * Remove EXPOSE in dockerfile * Update multidim-interop/go/v0.24/main.go Co-authored-by: João Oliveira <[email protected]> * Update multidim-interop/go/v0.22/main.go Co-authored-by: João Oliveira <[email protected]> * Update multidim-interop/go/v0.23/main.go Co-authored-by: João Oliveira <[email protected]> * Go nits * Cleanup Rust makefile * add working ping test (js) or multidim-interop (#98) * add working ping test (js) or multidim-interop * Add JS-libp2p to interop tests * ping libp2p-js (wo): resolve PR comments * Add yamux js-libp2p test Co-authored-by: Marco Munizaga <[email protected]> * Fix Go err * Ignore errors when shutting down * Fix err * Rename workflow * Remove rust v0.49 * Bump up timeouts Co-authored-by: João Oliveira <[email protected]> Co-authored-by: Glen De Cauwsemaecker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can test it yourself:
Haven't hooked it up to Go/Rust yet. Let me know if this PR suffices for you or if you need me to undertake some more steps.
In function of #97.