remove Noise Pipes and padding within payloads #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanb
reviewed
Apr 7, 2020
Co-Authored-By: Roman Borschel <[email protected]>
raulk
approved these changes
Apr 20, 2020
Comment on lines
+172
to
+174
| noise-libp2p is initialized and used for all sessions. Implementations SHOULD | ||
| NOT store the static Noise key to disk, as there is no benefit and a hightened | ||
| risk of exposure. |
There was a problem hiding this comment.
Reversing the suggestion makes sense now, as the handshake that would've benefitted from a long-lived/persisted key is now gone (the IK handshake).
This was referenced Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes Noise Pipes from the noise-libp2p spec, and also removes the padding within encrypted payloads.
Apologies to anyone who was waiting on this or was confused about the current state of the spec; this took me a lot longer than it should have :)
These changes bring the spec in line with the current Go and JavaScript implementations.
cc noise-libp2p IG: @raulk, @tomaka, @romanb, @shahankhatch, @Mikerah,
@djrtwo, @dryajov, @mpetrunic, @AgeManning, @morrigan, @araskachoi,
@mhchia