Refactor tests #145
Merged
Refactor tests #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures we are only accessing the public API of the crate.
This is a more flexible API.
This makes for a cleaner call-site.
This was referenced Oct 24, 2022
mxinden
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Thanks.
Am I correct assuming that you moved to tests/ to make sure we test the external API of the crate @thomaseizinger?
One comment, otherwise looks good to me.
| @@ -56,7 +56,7 @@ fn prop_config_send_recv_single() { | |||
| .expect("send_recv") | |||
| }; | |||
|
|
|||
| let result = futures::join!(server, client).1; | |||
| let result = futures::future::join(server, client).await.1; | |||
| @@ -131,16 +131,19 @@ impl Stream { | |||
| self.id | |||
| } | |||
|
|
|||
| pub fn is_write_closed(&self) -> bool { | |||
There was a problem hiding this comment.
Is this a breaking change? If so, this would require a changelog entry.
There was a problem hiding this comment.
Adding a new function is not a breaking change I believe!
Yes! |
mxinden
approved these changes
Nov 2, 2022
| @@ -131,16 +131,19 @@ impl Stream { | |||
| self.id | |||
| } | |||
|
|
|||
| pub fn is_write_closed(&self) -> bool { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #142, I had a look at the tests and I found them rather hard to understand.
This PR attempts to improve this situation. It is a clean refactoring, no behaviour has been changed and should thus hopefully be non-controversial.