Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(floodsub): change naming conventions #5855

Merged
merged 8 commits into from
Feb 12, 2025

Conversation

dariusc93
Copy link
Member

Description

related to #2217.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

protocols/floodsub/CHANGELOG.md Outdated Show resolved Hide resolved
@dariusc93 dariusc93 marked this pull request as ready for review February 12, 2025 10:50
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for revamping this Darius!

@jxs jxs added the send-it label Feb 12, 2025
@mergify mergify bot merged commit a966f62 into libp2p:master Feb 12, 2025
70 of 71 checks passed
jxs pushed a commit that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants