Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): remove upgrade::transfer module #4788

Merged
merged 6 commits into from
Nov 2, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
See [PR 4695](https://github.com/libp2p/rust-libp2p/pull/4695).
- Remove deprecated functions from `ListenerId`.
See [PR 4736](https://github.com/libp2p/rust-libp2p/pull/4736).
- Remove `upgrade::transfer` module.
See [issue 4011](https://github.com/libp2p/rust-libp2p/issues/4011) for details.
See [PR XXXX](https://github.com/libp2p/rust-libp2p/pull/XXXX).

## 0.40.1

Expand Down
7 changes: 1 addition & 6 deletions core/src/upgrade.rs
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ mod error;
mod pending;
mod ready;
mod select;
mod transfer;

pub(crate) use apply::{
apply, apply_inbound, apply_outbound, InboundUpgradeApply, OutboundUpgradeApply,
Expand All @@ -73,11 +72,7 @@ pub(crate) use error::UpgradeError;
use futures::future::Future;

pub use self::{
denied::DeniedUpgrade,
pending::PendingUpgrade,
ready::ReadyUpgrade,
select::SelectUpgrade,
transfer::{read_length_prefixed, read_varint, write_length_prefixed, write_varint},
denied::DeniedUpgrade, pending::PendingUpgrade, ready::ReadyUpgrade, select::SelectUpgrade,
};
pub use crate::Negotiated;
pub use multistream_select::{NegotiatedComplete, NegotiationError, ProtocolError, Version};
Expand Down
220 changes: 0 additions & 220 deletions core/src/upgrade/transfer.rs

This file was deleted.